Add integration test for LOOKUP JOIN on remotes after STATS #134127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
luigidellaquila
added
>test
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
reviewed
Sep 4, 2025
Comment on lines
291
to
302
| var ex = expectThrows( | ||
| VerificationException.class, | ||
| () -> runQuery( | ||
| "FROM c*:logs-* | EVAL lookup_key = v | STATS lookup_key = max(lookup_key) | LOOKUP JOIN values_lookup ON lookup_key", | ||
| randomBoolean() | ||
| ) | ||
| ); | ||
| assertThat( | ||
| ex.getMessage(), | ||
| containsString("LOOKUP JOIN with remote indices can't be executed after [STATS lookup_key = max(lookup_key)]") | ||
| ); | ||
| } |
There was a problem hiding this comment.
Nit: this could be simplified to:
Suggested change
| var ex = expectThrows( | |
| VerificationException.class, | |
| () -> runQuery( | |
| "FROM c*:logs-* | EVAL lookup_key = v | STATS lookup_key = max(lookup_key) | LOOKUP JOIN values_lookup ON lookup_key", | |
| randomBoolean() | |
| ) | |
| ); | |
| assertThat( | |
| ex.getMessage(), | |
| containsString("LOOKUP JOIN with remote indices can't be executed after [STATS lookup_key = max(lookup_key)]") | |
| ); | |
| } | |
| expectThrows( | |
| VerificationException.class, | |
| containsString("LOOKUP JOIN with remote indices can't be executed after [STATS lookup_key = max(lookup_key)]"), | |
| () -> runQuery( | |
| "FROM c*:logs-* | EVAL lookup_key = v | STATS lookup_key = max(lookup_key) | LOOKUP JOIN values_lookup ON lookup_key", | |
| randomBoolean() | |
| ) | |
| ); | |
| } |
idegtiarenko
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an integration test for queries where a LOOKUP JOIN is executed after a pipeline breaker